Brian Paul <[EMAIL PROTECTED]> wrote:
> Andre� Werthmann <[EMAIL PROTECTED]> wrote to point out a
> likely typo in src/X86/assyntax.h
>
> Line 1465 reads:
>
> #define P_ARG3(a, b) a, b, c
>
> But should probably be:
>
> #define P_ARG3(a, b, c) a, b, c
>
> Looks good to me. If one of you who've worked on this code could
> verify this, that would be great.
Actually it appears to be more deep rooted than that. This macros
appears to only be used by the Intel SSE stuff, which is not yet
being used. If you look further down where it is used in the rest of
the code, it only passes two arguments to the function! I am not at
all familiar with this code, but I suspect the lines:
#define CMPEQPS(a, b) cmpeqps P_ARG3(a, b)
#define CMPLTPS(a, b) cmpltps P_ARG3(a, b)
should be:
#define CMPEQPS(a, b) cmpeqps P_ARG2(a, b)
#define CMPLTPS(a, b) cmpltps P_ARG2(a, b)
while:
#define SHUFPS(a, b, c) shufps P_ARG3(a, b, c)
will use the correct version of the P_ARG3 macro.
I don't want to change this as I have no way to test it. Perhaps
someone who is working on Intel SSE stuff can do that...
Regards,
+---------------------------------------------------------------+
| SciTech Software - Building Truly Plug'n'Play Software! |
+---------------------------------------------------------------+
| Kendall Bennett | Email: [EMAIL PROTECTED] |
| Director of Engineering | Phone: (530) 894 8400 |
| SciTech Software, Inc. | Fax : (530) 894 9069 |
| 505 Wall Street | ftp : ftp.scitechsoft.com |
| Chico, CA 95928, USA | www : http://www.scitechsoft.com |
+---------------------------------------------------------------+
_______________________________________________
Mesa-dev maillist - [EMAIL PROTECTED]
http://lists.mesa3d.org/mailman/listinfo/mesa-dev
