>-----Original Message----- >From: Emil Velikov [mailto:[email protected]] >Sent: Monday, November 09, 2015 1:34 PM >To: Liu, Leo >Cc: [email protected] >Subject: Re: [PATCH] st/omx: straighten get/put_screen > >On 9 November 2015 at 15:22, Liu, Leo <[email protected]> wrote: >>>-----Original Message----- >>>From: Emil Velikov [mailto:[email protected]] >>>Sent: Monday, November 09, 2015 8:17 AM >>>To: [email protected] >>>Cc: [email protected]; Liu, Leo >>>Subject: [PATCH] st/omx: straighten get/put_screen >>> >>>The current code is busted in a number of ways. >>> >>> - initially checks for omx_display (rather than omx_screen), which >>>may or may not be around. >>> - blindly feeds the empty env variable string to loader_open_device() >> >> Should be treating empty string as one of incorrect string, which result in >> failing >open. >> Because user's intention is to use to env, if they put the empty string, here >should be getting failed. >> >I was leaning that the "check for empty string" approach was "the gallium way". >Although on second look the opposite seems to be more common, so consider it >gone. > Sound good.
>Btw. did any of the issues outlined became obvious with my previous comments >or am I too subtle ? Or you did not consider them something worth the hassle ? > I am with you. Perfection is always better. Thanks, Leo >Thanks >Emil _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
