Looks good to me. Chris Wilson <[email protected]> writes:
> @@ -324,10 +340,9 @@ _mesa_meta_pbo_GetTexSubImage(struct gl_context *ctx, > GLuint dims, > * property. > */ > image_height = packing->ImageHeight == 0 ? height : packing->ImageHeight; > - full_height = image_height * (depth - 1) + height; > > pbo_tex_image = create_texture_for_pbo(ctx, false, GL_PIXEL_PACK_BUFFER, > - width, full_height * depth, > + dims, width, height, depth, It looks like this bit was wrong previously and this patch fixes it. I think it would previously end up creating a texture that is height*depth² tall! However it probably wouldn't really matter because as far as I can tell this path is only used for an existing PBO so it wouldn't end up allocating any buffers or copying any data, it would just have the height wrong in the sampler state. Reviewed-by: Neil Roberts <[email protected]> Regards, - Neil _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
