Reviewed-by: Ilia Mirkin <[email protected]>
On Wed, Aug 26, 2015 at 1:20 PM, Ian Romanick <[email protected]> wrote: > From: Ian Romanick <[email protected]> > > main/bufferobj.c: In function '_mesa_handle_bind_buffer_gen': > main/bufferobj.c:915:37: warning: unused parameter 'target' > [-Wunused-parameter] > GLenum target, > ^ > > Signed-off-by: Ian Romanick <[email protected]> > --- > src/mesa/main/bufferobj.c | 7 +++---- > src/mesa/main/bufferobj.h | 1 - > src/mesa/main/varray.c | 3 +-- > 3 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c > index eab9cef..7c6c70a 100644 > --- a/src/mesa/main/bufferobj.c > +++ b/src/mesa/main/bufferobj.c > @@ -914,7 +914,6 @@ _mesa_free_buffer_objects( struct gl_context *ctx ) > > bool > _mesa_handle_bind_buffer_gen(struct gl_context *ctx, > - GLenum target, > GLuint buffer, > struct gl_buffer_object **buf_handle, > const char *caller) > @@ -977,7 +976,7 @@ bind_buffer_object(struct gl_context *ctx, GLenum target, > GLuint buffer) > else { > /* non-default buffer object */ > newBufObj = _mesa_lookup_bufferobj(ctx, buffer); > - if (!_mesa_handle_bind_buffer_gen(ctx, target, buffer, > + if (!_mesa_handle_bind_buffer_gen(ctx, buffer, > &newBufObj, "glBindBuffer")) > return; > } > @@ -4236,7 +4235,7 @@ _mesa_BindBufferRange(GLenum target, GLuint index, > } else { > bufObj = _mesa_lookup_bufferobj(ctx, buffer); > } > - if (!_mesa_handle_bind_buffer_gen(ctx, target, buffer, > + if (!_mesa_handle_bind_buffer_gen(ctx, buffer, > &bufObj, "glBindBufferRange")) > return; > > @@ -4288,7 +4287,7 @@ _mesa_BindBufferBase(GLenum target, GLuint index, > GLuint buffer) > } else { > bufObj = _mesa_lookup_bufferobj(ctx, buffer); > } > - if (!_mesa_handle_bind_buffer_gen(ctx, target, buffer, > + if (!_mesa_handle_bind_buffer_gen(ctx, buffer, > &bufObj, "glBindBufferBase")) > return; > > diff --git a/src/mesa/main/bufferobj.h b/src/mesa/main/bufferobj.h > index b5d73ae..b7154c5 100644 > --- a/src/mesa/main/bufferobj.h > +++ b/src/mesa/main/bufferobj.h > @@ -74,7 +74,6 @@ _mesa_free_buffer_objects(struct gl_context *ctx); > > extern bool > _mesa_handle_bind_buffer_gen(struct gl_context *ctx, > - GLenum target, > GLuint buffer, > struct gl_buffer_object **buf_handle, > const char *caller); > diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c > index 3bab985..7a1dddc 100644 > --- a/src/mesa/main/varray.c > +++ b/src/mesa/main/varray.c > @@ -1698,8 +1698,7 @@ vertex_array_vertex_buffer(struct gl_context *ctx, > struct gl_vertex_array_object > * Otherwise, we fall back to the same compat profile behavior as other > * object references (automatically gen it). > */ > - if (!_mesa_handle_bind_buffer_gen(ctx, GL_ARRAY_BUFFER, buffer, > - &vbo, func)) > + if (!_mesa_handle_bind_buffer_gen(ctx, buffer, &vbo, func)) > return; > } else { > /* The ARB_vertex_attrib_binding spec says: > -- > 2.1.0 > > _______________________________________________ > mesa-dev mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
