Ah, good catch. Looks good to me.
Reviewed-by: Neil Roberts <n...@linux.intel.com>
It seems a bit weird to use create_pbo=true at all for
glTexImage{1,2,3}D because in that case we are completely replacing the
texture. If the texture's buffer is busy instead of allocating a PBO we
might as well just directly allocate some new storage for the texture
and abandon the old storage. That would be a separate patch though and
either way I think this patch makes sense.
Anuj Phogat <anuj.pho...@gmail.com> writes:
> in case of glTex{Sub}Image{1,2,3}D().
I think in practice this patch only applies to glTexImage* (not
glTexSubImage*) doesn't it? It wouldn't make any sense to call
glTexSubImage without a PBO and with NULL pixels.
Regards,
- Neil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
