On 01.04.2015 00:36, Roland Scheidegger wrote:
> Am 31.03.2015 um 08:33 schrieb Michel Dänzer:
>> From: Michel Dänzer <[email protected]>
>>
>> Signed-off-by: Michel Dänzer <[email protected]>
>> ---
>>  src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp 
>> b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
>> index d4d453d..65d2896 100644
>> --- a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
>> +++ b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
>> @@ -256,8 +256,13 @@ disassemble(const void* func, llvm::raw_ostream & Out)
>>     }
>>  
>>  
>> +#if HAVE_LLVM >= 0x0307
>> +   OwningPtr<MCInstPrinter> Printer(
>> +         T->createMCInstPrinter(llvm::Triple(Triple), AsmPrinterVariant, 
>> *AsmInfo, *MII, *MRI));
>> +#else
>>     OwningPtr<MCInstPrinter> Printer(
>>           T->createMCInstPrinter(AsmPrinterVariant, *AsmInfo, *MII, *MRI, 
>> *STI));
>> +#endif
>>     if (!Printer) {
>>        Out << "error: no instruction printer for target " << Triple.c_str() 
>> << "\n";
>>        Out.flush();
>>
> 
> Does it actually work? I recently tried to do disassemble (more by
> accident, actually) with llvm 3.6 and it didn't work at all.

TBH I didn't test it, but I can see that it doesn't seem to work in any
useful way. Anyway, this change doesn't have any effect with LLVM 3.6,
so it sounds like it was already broken before.


> Anyway,
> 
> Reviewed-by: Roland Scheidegger <[email protected]>

Thanks.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to