On 14/01/15 20:53, Jan Vesely wrote:
these two patches fix cca 90 warnings when compiling src/mesa. The idea is to reduce warning bloat so that the remaining stuff can be looked into to check whether the warning hints at bigger issuegcc 4.9.2 with Wextra: from 2 -Warray-bounds 29 -Wmaybe-uninitialized 38 -Wmissing-field-initializers 200 -Wsign-compare 16 -Wtype-limits to 2 -Warray-bounds 29 -Wmaybe-uninitialized 38 -Wmissing-field-initializers 125 -Wsign-compare Jan Vesely (2): mesa: remove comparisons that are always true mesa: Fix some signed-unsigned comparison warnings src/mesa/main/bufferobj.c | 18 +++++++++--------- src/mesa/main/buffers.c | 2 +- src/mesa/main/clear.c | 2 +- src/mesa/main/dlist.c | 2 +- src/mesa/main/errors.c | 8 ++++---- src/mesa/main/fbobject.c | 9 ++++----- src/mesa/main/ffvertex_prog.c | 4 ++-- src/mesa/main/format_utils.h | 2 +- src/mesa/main/framebuffer.c | 2 +- src/mesa/main/matrix.c | 6 +++--- src/mesa/main/mipmap.c | 2 +- src/mesa/main/rastpos.c | 2 +- src/mesa/main/set.c | 2 +- src/mesa/main/texgetimage.c | 6 +++--- src/mesa/main/varray.c | 2 +- src/mesa/program/prog_execute.c | 3 +-- src/mesa/program/prog_optimize.c | 4 ++-- src/mesa/program/prog_print.c | 4 ++-- src/mesa/program/prog_statevars.c | 2 -- src/mesa/state_tracker/st_atom_blend.c | 2 +- src/mesa/state_tracker/st_atom_scissor.c | 2 +- src/mesa/state_tracker/st_atom_viewport.c | 2 +- src/mesa/state_tracker/st_cb_fbo.c | 6 +++--- src/mesa/state_tracker/st_draw.c | 2 +- src/mesa/state_tracker/st_extensions.c | 5 +++-- src/mesa/state_tracker/st_format.c | 3 ++- src/mesa/state_tracker/st_manager.c | 2 +- src/mesa/state_tracker/st_program.c | 2 +- src/mesa/vbo/vbo_exec_array.c | 3 ++- src/util/hash_table.c | 2 +- 30 files changed, 56 insertions(+), 57 deletions(-)
Thanks for this cleanup. Series looks good AFAICT. Reviewed-by: Jose Fonseca <[email protected]> Jose _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
