On Wed, Nov 12, 2014 at 9:35 PM, Kenneth Graunke <[email protected]> wrote:
> +vec4_visitor::emit_math(enum opcode opcode,
> + dst_reg dst, src_reg src0, src_reg src1)
I think you can make the arguments const references too?
> + if (brw->gen == 6 && dst.writemask != WRITEMASK_XYZW) {
> + /* MATH on Gen6 must be align1, so we can't do writemasks. */
> + math->dst = dst_reg(this, glsl_type::vec4_type);
> + math->dst.type = dst.type;
> + math->dst.writemask = WRITEMASK_XYZW;
I don't think you need to set the writemask (XYZW is the default).
> + emit(MOV(dst, src_reg(math->dst)));
> + } else if (brw->gen < 6) {
> + math->base_mrf = 1;
> + math->mlen = src1.file == BAD_FILE ? 1 : 2;
> }
> }
Series is
Reviewed-by: Matt Turner <[email protected]>
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
