On 26/08/14 08:41, Tapani wrote: > On 08/25/2014 07:19 PM, Eric Anholt wrote: >> Tapani Pälli <[email protected]> writes: >> >>> commit 4e64cfbb4 changed how gl_constant_value bool gets interpreted >>> with drivers, for swrast driver true should be 1. >>> >>> Signed-off-by: Tapani Pälli <[email protected]> >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82978 >> Everywhere else in swrast, true is 1.0f. Pretty sure you want fui(1.0) >> here. > > OK, my goal was to restore old behavior which seems that it had either value 1 > or 0, set by glUniform functions or a uniform initializer. Maybe conversion to > float is happening when reading the values from the uniform storage? > Would the final patch be nice to have in 10.3 or it's not something to worry about ? It seems like the issue was introduced in 10.3-dev.
-Emil > // Tapani > > _______________________________________________ > mesa-dev mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
