On Fri, Aug 1, 2014 at 6:48 AM, Neil Roberts <[email protected]> wrote:
> Jason Ekstrand <[email protected]> writes: > > > +bool > > +_mesa_meta_CopyImageSubData_uncompressed(struct gl_context *ctx, > > + struct gl_texture_image > *src_tex_image, > > + int src_x, int src_y, int > src_z, > > + struct gl_texture_image > *dst_tex_image, > > + int dst_x, int dst_y, int > dst_z, > > + int src_width, int src_height) > > +{ > > + GLuint src_view_texture = 0; > > + struct gl_texture_image *src_view_tex_image; > > + GLuint fbos[2]; > > ... > > > + _mesa_GenFramebuffers(2, fbos); > > ... > > > +cleanup: > > + _mesa_DeleteTextures(1, &src_view_texture); > > + > > + return success; > > +} > > It looks like the two FBOs are leaked. Maybe they should be added to the > cleanup step? > Done. Other than that, does this count as a R-B? --Jason > > Regards, > - Neil > _______________________________________________ > mesa-dev mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
