On 04/21/2014 03:57 PM, Fredrik Höglund wrote:
So here is version two of the ARB_multi_bind series.
This incorporates feedback from Brian, Matt and Francisco, and also
fixes an issue I happened to notice myself. It occurred to me that
the BindTexture driver hook doesn't have a parameter for the texture
index, and that drivers might want to know which texture was changed.
It turns out that the only driver that implements the hook is nouveau,
and the index is the only thing it cares about. So there is now a new
patch that adds an index parameter and adjusts the driver accordingly.
I have also updated my branch at:
git://people.freedesktop.org/~fredrik/mesa arb-multi-bind
The series looks good to me. Just some minor nit-picks. When we print
a GLsizei we need to use %d, not %u, since GLsizei is a signed type. I
think I saw about 10 instances of that.
For the series: Reviewed-by: Brian Paul <[email protected]>
BTW, do we have piglit tests for this extension?
Note that the BindBuffers patches have still not been reviewed.
That's a different patch series? I don't remember it.
-Brian
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
