On Tue, Apr 8, 2014 at 2:52 AM, Eric Anholt <[email protected]> wrote: > Chia-I Wu <[email protected]> writes: > >> From: Chia-I Wu <[email protected]> >> >> Given >> >> mov vgrf7, vgrf9.xyxz >> add vgrf9.xyz, vgrf4.xyzw, vgrf5.xyzw >> add vgrf10.x, vgrf6.xyzw, vgrf7.wwww >> >> the last instruction would be wrongly changed to >> >> add vgrf10.x, vgrf6.xyzw, vgrf9.zzzz >> >> during copy propagation. >> >> The issue is that when deciding if a record should be cleared, the old code >> checked for >> >> inst->dst.writemask & (1 << ch) >> >> instead of >> >> inst->dst.writemask & (1 << BRW_GET_SWZ(src->swizzle, ch)) >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76749 >> Signed-off-by: Chia-I Wu <[email protected]> >> Cc: Jordan Justen <[email protected]> >> Cc: Matt Turner <[email protected]> > > Reviewed-by: Eric Anholt <[email protected]> > > I've just sent a patch for adding a unit test of copy propagation -- it > would be nice to see an additional test on top of that for this bug. Nice. I will do that maybe tomorrow.
-- [email protected] _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
