On Mon, Jan 20, 2014 at 07:54:25PM -0800, Paul Berry wrote: > On 20 December 2013 06:39, Topi Pohjolainen <[email protected]> > wrote: > > diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h > b/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h > index 1ecf076..3f2301c 100644 > --- a/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h > +++ b/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h > @@ -162,6 +162,24 @@ protected: > brw_RNDD(&func, dst, src); > } > > + inline void emit_if(int op, > + const struct brw_reg &x, > + const struct brw_reg &y) > + { > + brw_CMP(&func, vec16(brw_null_reg()), op, x, y); > + brw_IF(&func, BRW_EXECUTE_16); > + } > > Can we maybe call tihs "emit_cmp_if()", so that it's clear when looking at > the caller that it performs both a CMP and an IF?
Yes, clearly better, I'll revise. > > With that change, this patch is: > > Reviewed-by: Paul Berry <[email protected]> _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
