On 26 November 2013 00:02, Francisco Jerez <[email protected]> wrote:
>
> +enum glsl_image_dim {
> + GLSL_IMAGE_DIM_1D,
> + GLSL_IMAGE_DIM_2D,
> + GLSL_IMAGE_DIM_3D,
> + GLSL_IMAGE_DIM_RECT,
> + GLSL_IMAGE_DIM_CUBE,
> + GLSL_IMAGE_DIM_BUFFER,
> + GLSL_IMAGE_DIM_MS
> +};
> +
>
glsl_image_dim seems redundant with glsl_sampler_dim (they are identical
except that the order is different, and glsl_sampler_dim includes the extra
value GLSL_SAMPLER_DIM_EXTERNAL). I'd prefer to just use one enum for both
purposes, and don't create any image types using GLSL_SAMPLER_DIM_EXTERNAL.
With that changed, this patch is:
Reviewed-by: Paul Berry <[email protected]>
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
