On 11/10/13 20:44, Tom Stellard wrote: > On Fri, Oct 11, 2013 at 02:09:57PM +0100, Emil Velikov wrote: >> On 07/10/13 18:53, Emil Velikov wrote: >>> On 07/10/13 16:48, Tom Stellard wrote: >>>> On Sat, Sep 28, 2013 at 03:46:21PM +0100, Emil Velikov wrote: >>>>> Use PKG_CHECK_MODULE over requesting the user to setup the >>>>> option at configure time. Drop unused EXPAT_INCLUDE and add >>>>> EXPAT_CFLAGS to all classic/dri and gallium/dri targets. >>>>> >>>>> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> >>>>> --- >> [...] >>>> >>>> Is it possible to get the same behavior as the --with-expat option by >>>> setting EXPAT_* environment variables at configure time? If so, it would >>>> be nice to add a note to the commit message explaining how to do this. >>>> >>> Very nice point Tom. >>> No, it cannot in it's current form. My intent was so standardise >>> handling of mesa dependencies. That means it will break on certain >>> (hacky) setups, where expat is available without expat.pc or when they >>> are linking against system libdrm, libudev, etc. and custom expat. It's >>> a all or nothing solution. >>> >>> From my POV the solution for those people would be have an enviroment >>> where all the libraries are present (coordinated) in a single location >>> (available to pkg-config via PKG_CONFIG_PATH). >>> >>> FWIW Archlinux, Gentoo, Fedora, OpenSUSE and Debian do not use the flag. >>> >>> Sorry for the lengthy explanation. >>> >> Hi Tom, >> >> I believe that this is not the answer you were hoping for, nor the one I >> wanted to give. >> >> With that said if you have any objections feel free to drop the patch, >> as long as the rest of the series still lives :) >> > > I don't have any objections to this patch, but I think you should add a > note to the commit message that the --with-expat flag is being removed > and that build configurations that use it are no longer supported. > Should have seen this in your previous question. Done.
> It may be hard to track down who, if anyone, is using this flag, so I > think the best thing to do would be to commit this and see who complains. > Hehe nice one :) > -Tom > >> The whole annotated and rebased series is available in the >> xorg-cleanups-v2 branch at https://github.com/evelikov/Mesa.git Rebased and pushed to the same branch :P Cheers Emil >> >> ~Emil >> >>> Cheers >>> Emil >>> >>>> -Tom >>>>> >> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
