The first comment was a bit stale; there are more kinds of surfaces than textures and pull constants.
The second was a leftover "to do" comment for something I already did. Signed-off-by: Kenneth Graunke <[email protected]> --- src/mesa/drivers/dri/i965/brw_vs_surface_state.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vs_surface_state.c b/src/mesa/drivers/dri/i965/brw_vs_surface_state.c index dbf26f4..985fd67 100644 --- a/src/mesa/drivers/dri/i965/brw_vs_surface_state.c +++ b/src/mesa/drivers/dri/i965/brw_vs_surface_state.c @@ -163,9 +163,7 @@ brw_vec4_upload_binding_table(struct brw_context *brw, gen7_create_shader_time_surface(brw, &stage_state->surf_offset[SURF_INDEX_VEC4_SHADER_TIME]); } - /* Skip making a binding table if we don't use textures or pull - * constants. - */ + /* If there are no surfaces, skip making the binding table altogether. */ const unsigned entries = prog_data->binding_table_size; if (entries == 0) { if (stage_state->bind_bo_offset != 0) { @@ -175,9 +173,6 @@ brw_vec4_upload_binding_table(struct brw_context *brw, return; } - /* Might want to calculate nr_surfaces first, to avoid taking up so much - * space for the binding table. - */ bind = brw_state_batch(brw, AUB_TRACE_BINDING_TABLE, sizeof(uint32_t) * entries, 32, &stage_state->bind_bo_offset); -- 1.8.3.4 _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
