Am 15.08.2013 14:54, schrieb Emil Velikov:
On 15/08/13 13:41, Rico Schüller wrote:
On 15.08.2013 02:10, Emil Velikov wrote:
Fix a typo introduced with commit d1ba1055d9 -
vl: Add support for max level query v2
Cc: Rico Schüller <[email protected]>
Cc: Christian König <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68126
Signed-off-by: Emil Velikov <[email protected]>
---
FWIW the original patch could have introduced default params for all
profiles,
and let the individual driver provide their own function to ease
duplication.
A call to get_params(VIDEO_CAP_SUPPORTED) ensures that we do not
request the
CAP_MAX_LEVEL of a unsupported profile
And what are the correct default values? Are these the values which most
hardware can do (at this time) or the maximum values? (for reference
only for H.264 see: http://en.wikipedia.org/wiki/H.264#Levels ) It's
pretty much likely that some video decoding units may have different
supported levels and then we would add that back in again. I'm not sure
this is really better. Does something like the attached meet your needs?
I was thinking that the ones used by most hardware can be considered
default. Anyway all this is a silly bikeshedding, which I could have
omitted.
Patch looks good, thanks.
Only for the shader based MPEG2 implementation a sane fallback is
needed, so the original implementation is actually already fine, cause
if anybody things the levels should be different for a specific driver
can just change that driver.
Christian.
Emil
Thanks for the fix.
Cheers
Rico
src/gallium/drivers/nouveau/nouveau_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/nouveau_video.c
b/src/gallium/drivers/nouveau/nouveau_video.c
index 1563b22..5c4ec0f 100644
--- a/src/gallium/drivers/nouveau/nouveau_video.c
+++ b/src/gallium/drivers/nouveau/nouveau_video.c
@@ -863,7 +863,7 @@ nouveau_screen_get_video_param(struct pipe_screen
*pscreen,
case PIPE_VIDEO_CAP_SUPPORTS_PROGRESSIVE:
return true;
case PIPE_VIDEO_CAP_MAX_LEVEL:
- return vl_level_supported(screen, profile);
+ return vl_level_supported(pscreen, profile);
default:
debug_printf("unknown video param: %d\n", param);
return 0;
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
