On 16 December 2012 07:49, Brian Paul <[email protected]> wrote:
> On Sat, Dec 15, 2012 at 11:09 PM, Paul Berry <[email protected]> > wrote: > > The rather unweildy logic for determining this condition was repeated > > in a large number of places. This patch consolidates it to a single > > inline function. > > > > > > @@ -111,4 +113,11 @@ _mesa_PauseTransformFeedback(void); > > extern void GLAPIENTRY > > _mesa_ResumeTransformFeedback(void); > > > > +static inline bool > > +is_transform_feedback_active_and_unpaused(struct gl_context *ctx) > > +{ > > + return ctx->TransformFeedback.CurrentObject->Active && > > + !ctx->TransformFeedback.CurrentObject->Paused; > > +} > > Non-private core Mesa functions should have the _mesa_ prefix. It's a > long name already. Maybe use the "xfb" abbreviation? > > The ctx parameter could be const-qualified. > Ok, I'll change this. Thanks. > > Reviewed-by: Brian Paul <[email protected]> >
_______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
