On 12/05/2012 01:49 AM, Stefan Dösinger wrote:

In the future, please send patches using git-send-mail. It makes it easier for people to reply with comments in-line with the patch.

In spite of that, this patch looks good. Does it fix any known bugzilla entries? If so, those should be mentioned in the commit message like:

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=#####

I also think this should get cherry-picked back to stable branches, so you should add the following text to the commit message:

NOTE: This is a candidate for stable release branches.

Other than that,

Reviewed-by: Ian Romanick <[email protected]>

_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to