Chad Versace <chad.vers...@linux.intel.com> writes: > Fixes piglit tests "unpack-teximage2d --pbo=* --format=GL_BGRA" on > Sandybridge+. > > The fastpath was checking an incomplete set of pixel unpack state. This > patch adds checks for all the fields of gl_pixelstore_attrib that affect > 2D texture uploads. Also, it begins permitting the case where > GL_UNPACK_ROW_LENGTH is 0. > > Ideally, we would just ask a unicorn to JIT this fastpath for us in > a way that safely handles the unpacking state. Until then, it's safer if > only a small set of situations activate the fastpath.
> + packing->BufferObj != ctx->Shared->NullBufferObj || I think this is usually _mesa_is_bufferobj(packing->BufferObj). Other than that, Reviewed-by: Eric Anholt <e...@anholt.net>
pgpanlortV0eV.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
