On 6/11/12, Eric Anholt <[email protected]> wrote: > On Mon, 11 Jun 2012 10:02:34 -0700 (PDT), Jose Fonseca <[email protected]> > wrote: >> This breaks the SCons build, which parses src/glsl/Makefile.sources, >> and can't understand "$(GLSL_SRCDIR)/" as it only supports a simple >> subset of Make syntax. >> >> Is there some other way to achieve this effect, without changing >> src/glsl/Makefile.sources? > > Thanks for pushing the fix -- looks fine. > > It turns out that while working on my next series of automaking, I've > found that there's a knob to tell automake to stfu about use of gmake > features, so this dance may not actually be required.
FYI, it's -Wall in AM_INIT_AUTOMAKE from e4c97f1e6 that's doing this. foreign shuts off the portability warnings. http://www.gnu.org/software/automake/manual/automake.html#automake-Invocation http://www.gnu.org/software/automake/manual/automake.html#Strictness Since I'm pretty sure there are quite a few parts of the build that depend on GNU Make, I'd suggest either dropping -Wall or adding -Wno-portability. I don't see how -Wall is helping here, though. -- Dan _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
