On 06/11/2012 12:59 AM, Pauli Nieminen wrote:
gl_texture_image structure always holds size and internal format before
TexImage driver hook is called. Those passing same information in
function parameters only duplicates information making the interface
harder to understand.

Signed-off-by: Pauli Nieminen<[email protected]>
---
  src/mesa/drivers/dri/intel/intel_tex_image.c   |   22 +++++++--------
  src/mesa/drivers/dri/nouveau/nouveau_texture.c |   21 ++++++---------
  src/mesa/drivers/dri/radeon/radeon_texture.c   |   34 ------------------------
  src/mesa/main/dd.h                             |    2 --
  src/mesa/main/teximage.c                       |    7 +++--
  src/mesa/main/texobj.c                         |    3 +--
  src/mesa/main/texstore.c                       |    9 +++----
  src/mesa/main/texstore.h                       |    2 --
  src/mesa/state_tracker/st_cb_texture.c         |   21 ++++++---------
  9 files changed, 33 insertions(+), 88 deletions(-)

I was planning on doing this too someday.  Looks good.

For patches 2,3,4: Reviewed-by: Brian Paul <[email protected]>
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to