On Wed, Mar 4, 2020 at 6:37 PM Emil Velikov <[email protected]> wrote:
>
> Hi Mark,
>
> On Fri, 21 Feb 2020 at 12:20, Mark Menzynski <[email protected]> wrote:
>
> > - ret = nv50_ir_generate_code(info);
> > + /* these fields might be overwritten by the compiler */
> > + info_out.bin.smemSize = prog->cp.smem_size;
> > + info_out.io.genUserClip = prog->vp.num_ucps;
> > +
> I suspect that these two should be not be the out "version" of the
> variables, but more like in the final patch.
> Especially since nv50_ir_generate_code indiscriminately overrides info_out.
>
> While I haven't looked at the code too closely, if does seem like this
> commit causes an intermittent regression... Or perhaps we're lucky and
> things just work ;-)
>
> Either way, huge thanks for the update. Doubt I'll have the chance to
> do a proper review, despite that the performance numbers look great.
>
seems like Mark fixed that part in the 7th patch, but yeah, it should
be fixed in this patch instead.
> > + ret = nv50_ir_generate_code(info, &info_out);
> > if (ret) {
> > NOUVEAU_ERR("shader translation failed: %i\n", ret);
> > goto out;
> > }
> >
>
> Thanks
> Emil
>
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
