On Thu, 29 Aug 2019 14:53:10 +0200
Rohan Garg <rohan.g...@collabora.com> wrote:
> is_scanout is not used anywhere and can be inferred within
> panfrost_drm_submit_vs_fs_job if required.
Signed-off-by tag is missing. Looks good otherwise.
Reviewed-by: Boris Brezillon <boris.brezil...@collabora.com>
> ---
> src/gallium/drivers/panfrost/pan_drm.c | 2 +-
> src/gallium/drivers/panfrost/pan_job.c | 3 +--
> src/gallium/drivers/panfrost/pan_screen.h | 3 +--
> 3 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/src/gallium/drivers/panfrost/pan_drm.c
> b/src/gallium/drivers/panfrost/pan_drm.c
> index c3693bff56a..8e05fc936b2 100644
> --- a/src/gallium/drivers/panfrost/pan_drm.c
> +++ b/src/gallium/drivers/panfrost/pan_drm.c
> @@ -292,7 +292,7 @@ panfrost_drm_submit_job(struct panfrost_context *ctx, u64
> job_desc, int reqs)
> }
>
> int
> -panfrost_drm_submit_vs_fs_job(struct panfrost_context *ctx, bool has_draws,
> bool is_scanout)
> +panfrost_drm_submit_vs_fs_job(struct panfrost_context *ctx, bool has_draws)
> {
> int ret = 0;
>
> diff --git a/src/gallium/drivers/panfrost/pan_job.c
> b/src/gallium/drivers/panfrost/pan_job.c
> index 4d8ec2eadc9..f5bbd04b913 100644
> --- a/src/gallium/drivers/panfrost/pan_job.c
> +++ b/src/gallium/drivers/panfrost/pan_job.c
> @@ -208,9 +208,8 @@ panfrost_job_submit(struct panfrost_context *ctx, struct
> panfrost_job *job)
> panfrost_scoreboard_link_batch(job);
>
> bool has_draws = job->last_job.gpu;
> - bool is_scanout = panfrost_is_scanout(ctx);
>
> - ret = panfrost_drm_submit_vs_fs_job(ctx, has_draws, is_scanout);
> + ret = panfrost_drm_submit_vs_fs_job(ctx, has_draws);
>
> if (ret)
> fprintf(stderr, "panfrost_job_submit failed: %d\n", ret);
> diff --git a/src/gallium/drivers/panfrost/pan_screen.h
> b/src/gallium/drivers/panfrost/pan_screen.h
> index 35fb8de2628..02e8a96fabe 100644
> --- a/src/gallium/drivers/panfrost/pan_screen.h
> +++ b/src/gallium/drivers/panfrost/pan_screen.h
> @@ -165,8 +165,7 @@ panfrost_drm_import_bo(struct panfrost_screen *screen,
> int fd);
> int
> panfrost_drm_export_bo(struct panfrost_screen *screen, const struct
> panfrost_bo *bo);
> int
> -panfrost_drm_submit_vs_fs_job(struct panfrost_context *ctx, bool has_draws,
> - bool is_scanout);
> +panfrost_drm_submit_vs_fs_job(struct panfrost_context *ctx, bool has_draws);
> void
> panfrost_drm_force_flush_fragment(struct panfrost_context *ctx,
> struct pipe_fence_handle **fence);
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
