On Thu, 8 Aug 2019 at 16:50, Rob Herring <[email protected]> wrote: > > On Wed, Aug 7, 2019 at 5:47 PM Alyssa Rosenzweig > <[email protected]> wrote: > > > > > This is using the > > > untranslated flags, but I think it should be the 'translated_flags' as > > > those are the ones changing the allocation. > > > > It's a little more complex than that. There some hypothetical > > untranslated flags that I would want to match on. For instance, future > > CPU read-only/write-only modifiers -- those affect the mmap (and need to > > be accounted for in the BO cache) but aren't specified as > > translated_flags to the kernel. > > I'll still argue that we shouldn't leave cached BOs mmap'ed so that > example would be mute. > > The more bits we have to match on, the less effective the BO cache > will be. Either we should use translated_flags or we should filter the > untranslated flags to the ones we care about. The latter would be more > flexible I guess.
Yeah, there's lots to optimize still, fortunately :) Cheers, Tomeu _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
