What we call GROWABLE in Mesa corresponds to the HEAP BO flag in the kernel. These buffers cannot be memory mapped in the CPU side at the moment, so make sure they are also marked INVISIBLE.
This allows us to allocate a big heap upfront (16MB) without actually reserving space unless it's needed. Signed-off-by: Tomeu Vizoso <[email protected]> --- src/gallium/drivers/panfrost/pan_drm.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c index a3f35aed4d0f..122bc5f3db36 100644 --- a/src/gallium/drivers/panfrost/pan_drm.c +++ b/src/gallium/drivers/panfrost/pan_drm.c @@ -91,11 +91,15 @@ panfrost_drm_create_bo(struct panfrost_screen *screen, size_t size, /* To maximize BO cache usage, don't allocate tiny BOs */ size = MAX2(size, 4096); + /* GROWABLE BOs cannot be mmapped */ + if (flags & PAN_ALLOCATE_GROWABLE) + assert(flags & PAN_ALLOCATE_INVISIBLE); + unsigned translated_flags = 0; if (screen->kernel_version >= 1) { - //if (flags & PAN_ALLOCATE_GROWABLE) - // translated_flags |= PANFROST_BO_HEAP; + if (flags & PAN_ALLOCATE_GROWABLE) + translated_flags |= PANFROST_BO_HEAP; if (!(flags & PAN_ALLOCATE_EXECUTE)) translated_flags |= PANFROST_BO_NOEXEC; } -- 2.20.1 _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
