On Monday, 2019-07-08 11:58:11 -0700, Nataraj Deshpande wrote:
> color_buffers[] is currently hard coded to 3 for android which fails
> in droid_window_dequeue_buffer when ANativeWindow creates 4 color_buffers
> on ChromeOS while querying buffer age during dEQP partial_update tests.
>
> Fixes dEQP-EGL.functional.partial_update* tests on chromebooks with
> enabling EGL_KHR_partial_update.
>
> Fixes: 2acc69da8ce "EGL/Android: Add EGL_EXT_buffer_age extension"
> Signed-off-by: Nataraj Deshpande <nataraj.deshpa...@intel.com>
> ---
> src/egl/drivers/dri2/egl_dri2.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/src/egl/drivers/dri2/egl_dri2.h b/src/egl/drivers/dri2/egl_dri2.h
> index 943ff18..635a100 100644
> --- a/src/egl/drivers/dri2/egl_dri2.h
> +++ b/src/egl/drivers/dri2/egl_dri2.h
> @@ -322,13 +322,11 @@ struct dri2_egl_surface
> __DRIimage *dri_image_front;
>
> /* Used to record all the buffers created by ANativeWindow and their ages.
> - * Usually Android uses at most triple buffers in ANativeWindow
> - * so hardcode the number of color_buffers to 3.
Might be good to update the comment instead of removing it, but either way:
Acked-by: Eric Engestrom <e...@engestrom.ch>
> */
> struct {
> struct ANativeWindowBuffer *buffer;
> int age;
> - } color_buffers[3], *back;
> + } color_buffers[4], *back;
> #endif
>
> /* surfaceless and device */
> --
> 2.7.4
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
