On Fri, May 11, 2012 at 11:00 AM, Jose Fonseca <jfons...@vmware.com> wrote: > > > ----- Original Message ----- >> On Fri, May 11, 2012 at 10:03 AM, Francisco Jerez >> <curroje...@riseup.net> wrote: >> > jfons...@vmware.com writes: >> > >> >> From: José Fonseca <jfons...@vmware.com> >> >> >> >> For consistency. >> > >> > I'm OK with this change, but, just so that you know, the only >> > reason I >> > called it TGSI_BUFFER instead of TGSI_TEXTURE_BUFFER was to keep it >> > consistent with the pipe_texture_target enumeration. >> > >> >> I think plain TGSI_BUFFER makes more sense from an OpenCL >> perspective. > > OpenGL/OpenCL uses the same symbols for multiple things. And > pipe_texture_target was modelled after it. > > But I think that in mesa/gallium, all enumerations should have an unique > prefix, otherwise code becomes quite confusing, as it looks like different > quantities are being mixed, auto-complete will skip it, etc. > > Therefore, if buffers should not be preceeded by TEXTURE_, then we'll need > TGSI_FOO_BUFFER, TGSI_FOO_TEXTURE_2D, etc. For example, FOO could be > RESOURCE, SAMPLER, etc. > > PIPE_BUFFER too, should eventually be fixed.
Makes sense. Works for me. Alex > > > Jose _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
