When we switched over to 1-bit booleans, the radv query shaders ended up still using 32-bit booleans for most stuff. While this is technically valid from an IR perspective, most of the NIR passes don't really support 32-bit booleans correctly anymore now that we've moved to 1-bit. This tiny series attempts to convert the radv query shaders over to using 1-bit Booleans.
I've only compile-tested it and read through it a couple times but am not really set up for testing radv. I would very much appreciate if someone more familiar with radv could review and test these patches (and possibly rewrite them if appropriate). Cc: Dave Airlie <airl...@redhat.com> Cc: Timothy Arceri <tarc...@itsqueeze.com> Cc: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> Jason Ekstrand (2): radv/query: Add a nir_flag_set helper radv/query: Use 1-bit booleans in query shaders src/amd/vulkan/radv_query.c | 67 +++++++++++++++++++------------------ 1 file changed, 34 insertions(+), 33 deletions(-) -- 2.19.2 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
