On Friday, 2018-11-02 14:40:50 -0700, Eric Anholt wrote: > Previously the debug would be: > > libEGL debug: No DRI config supports native format 0x20203852 > libEGL debug: No DRI config supports native format 0x38385247 > > but > > libEGL debug: No DRI config supports native format R8 > libEGL debug: No DRI config supports native format GR88 > > is a lot easier to understand.
Series is Reviewed-by: Eric Engestrom <[email protected]> There's probably other places that could use this more descriptive error message :) > --- > src/egl/drivers/dri2/platform_drm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/egl/drivers/dri2/platform_drm.c > b/src/egl/drivers/dri2/platform_drm.c > index 68ec8322e978..fb346e007332 100644 > --- a/src/egl/drivers/dri2/platform_drm.c > +++ b/src/egl/drivers/dri2/platform_drm.c > @@ -664,8 +664,9 @@ drm_add_configs_for_visuals(_EGLDriver *drv, _EGLDisplay > *disp) > > for (unsigned i = 0; i < ARRAY_SIZE(format_count); i++) { > if (!format_count[i]) { > - _eglLog(_EGL_DEBUG, "No DRI config supports native format 0x%x", > - visuals[i].gbm_format); > + struct gbm_format_name_desc desc; > + _eglLog(_EGL_DEBUG, "No DRI config supports native format %s", > + gbm_format_get_name(visuals[i].gbm_format, &desc)); > } > } > > -- > 2.19.1 > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
