Patches 1 through 5 and 7 are Reviewed-by: Ian Romanick <[email protected]>
Patch 6 is Acked-by: Ian Romanick <[email protected]> Someone more familiar with those bits should look at patch 6. On 10/11/2018 02:32 PM, Jason Ekstrand wrote: > This simple check helps catch bugs early that can end up propagating > into later stages of the compile and triggering strange asserts. > --- > src/intel/compiler/brw_ir_allocator.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/intel/compiler/brw_ir_allocator.h > b/src/intel/compiler/brw_ir_allocator.h > index b1237ed38e7..9f124645ba2 100644 > --- a/src/intel/compiler/brw_ir_allocator.h > +++ b/src/intel/compiler/brw_ir_allocator.h > @@ -47,6 +47,7 @@ namespace brw { > unsigned > allocate(unsigned size) > { > + assert(size > 0); > if (capacity <= count) { > capacity = MAX2(16, capacity * 2); > sizes = (unsigned *)realloc(sizes, capacity * sizeof(unsigned)); > _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
