On Thu, 11 Oct 2018 at 18:35, Tapani Pälli <[email protected]> wrote:
> On 10/11/18 2:22 PM, Eric Engestrom wrote:
> > On Thursday, 2018-10-11 08:16:52 +0300, Tapani Pälli wrote:
> >> ping ... this fixes Android build as anv_device.c started to include
> >> "git_sha1.h" but build does not currently pass the path to this header.
> >
> > I don't know much about the android build system; is this the right way
> > to add a -I include path?
>
> I consider this the cleanest way and this is how it's done elsewhere in
> build.
>
It's one of the cleanest way indeed. The concept of "dependency" is
iffy, so a dummy static library is the best thing AFAICT.

Fwiw:
Reviewed-by: Emil Velikov <[email protected]>

-Emil
P.S. Don't be afraid to CC/ping me on patches like these.
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to