On Mon, 09 Apr 2012 23:29:09 -0700, Kenneth Graunke <[email protected]> wrote: > On 04/09/2012 02:22 PM, Eric Anholt wrote: > > @@ -1346,11 +1325,10 @@ emit_instructions(struct texenv_fragment_program *p) > > static struct gl_shader_program * > > create_new_program(struct gl_context *ctx, struct state_key *key) > > { > > - struct texenv_fragment_program p; > > + texenv_fragment_program p; > > unsigned int unit; > > _mesa_glsl_parse_state *state; > > > > - memset(&p, 0, sizeof(p)); > > Clearly you can't continue doing this memset, but I'm also wary of just > removing it. Nothing depends on these fields being init'd to zero? > > If they do, it's probably cleanest to add a constructor. Some of this > code could probably go there. > > Assuming the memset was just for paranoia: > Reviewed-by: Kenneth Graunke <[email protected]>
I went back and reviewed this inspection and by valgrind, and I'v pushed the series. Thanks for the review!
pgps1RfbZvDnV.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
