----- Original Message ----- > Jakob Bornecrantz <ja...@vmware.com> writes: > > > ----- Original Message ----- > >> Jakob Bornecrantz <ja...@vmware.com> writes: > >> > >> >> +libws_loader_la_LIBADD = \ > >> >> + $(top_srcdir)/src/gallium/winsys/sw/null/libws_null.la > >> >> + > >> >> +if HAVE_XLIB_LOADER_GALLIUM > >> >> +libws_loader_la_LIBADD += \ > >> >> + $(top_srcdir)/src/gallium/winsys/sw/xlib/libws_xlib.la > >> >> +AM_CFLAGS += -DHAVE_WS_LOADER_XLIB > >> >> +endif > >> > > >> > Ah so this explains the not sorting winsys dir, this shouldn't > >> > be done on the winsys this is for the target to keep track of. > >> > Just as it is the targets job to link libdrm. > >> > > >> > >> I had the feeling that letting a winsys link to another wouldn't > >> be > >> much of a problem, especially if all the winsys build system is > >> going to be converted to automake and we're going to get a more > >> automated dependency tracking. But, if we don't want to relax > >> that restriction anyway, the other possibility would be to define > >> a GALLIUM_WS_LOADER_LIBS variable at configure time containing all > >> the objects a target has to pull in order to link to the winsys > >> loader. Would that be OK with you? > > > > Sounds good with me. Under the scons build we usually put that > > calculation in the targets [1][2], but I guess for automake we > > want a more centralized approach. > > > > Updated patch series follows. I've used the configure variable > approach to avoid having to replicate the same logic in every target > that makes use of winsys/loader. '[PATCH 09/15] configure.ac: Don't > sort GALLIUM_WINSYS_DIRS' isn't necessary now. > > Jakob Bornecrantz <ja...@vmware.com> writes: > > > I'm not against this and the other change per say, I just > > wished all of the winsys's where converted at the same time. > > OK, I'm also leaving out the automake conversion of winsys/null and > winsys/xlib for a future patch series.
Patches 1, 10, 11 & 12 are Reviewed-by: Jakob Bornecrantz <ja...@vmware.com> I know to little about the TGSI code to feel comfortable to give a RB, but code wise the look good. Cheers, Jakob. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
