On Tue, Jun 19, 2018 at 8:32 AM, Ilia Mirkin <[email protected]> wrote: > On Tue, Jun 19, 2018 at 8:23 AM, Rob Clark <[email protected]> wrote: >> All of ARB_gpu_shader5 is most certainly not required for GLES 3.1 (most >> of it is in OES_gpu_shader5 on top of GLES 3.1). >> >> Signed-off-by: Rob Clark <[email protected]> >> --- >> I guess technically we depend on the tiniest sliver of ARB_gpu_shader5 >> but I'm not sure there is any better option than to ignore that. Is >> there actually some other driver that would accidentally expose 3.1 >> with this change? If not, I think the straightforward thing to do is >> to just drop the check for ARB_gpu_shader5. > > The tiniest sliver like all the various integer ops it adds and half > of texture gather? >
oh, I thought compute_version_es2() was already checking for ARB_texture_gather, but in fact it is not.. I'll respin this adding the check for ARB_texture_gather BR, -R > OTOH, I can't think of a driver that would have the other exts, but > not this stuff -- perhaps we can let it slide. > > If you rephrase the commit description to elaborate on the fact that > many bits *are* required, but there's no separate enable and it's not > worth adding one, > > Acked-by: Ilia Mirkin <[email protected]> > >> >> src/mesa/main/version.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c >> index 1bdccf4a1df..90979ed80f9 100644 >> --- a/src/mesa/main/version.c >> +++ b/src/mesa/main/version.c >> @@ -549,7 +549,6 @@ compute_version_es2(const struct gl_extensions >> *extensions, >> extensions->ARB_shading_language_packing && >> extensions->ARB_stencil_texturing && >> extensions->ARB_texture_multisample && >> - extensions->ARB_gpu_shader5 && >> extensions->EXT_shader_integer_mix); >> const bool ver_3_2 = (ver_3_1 && >> extensions->EXT_draw_buffers2 && >> -- >> 2.17.1 >> >> _______________________________________________ >> mesa-dev mailing list >> [email protected] >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
