On Fri, Jun 15, 2018 at 4:31 PM, Ilia Mirkin <[email protected]> wrote: > On Fri, Jun 15, 2018 at 4:24 PM, Rhys Perry <[email protected]> wrote: >> Signed-off-by: Rhys Perry <[email protected]> >> --- >> src/compiler/glsl/ast_to_hir.cpp | 5 +++++ >> src/compiler/glsl/glsl_parser_extras.cpp | 1 + >> src/compiler/glsl/glsl_parser_extras.h | 7 +++++++ >> src/mesa/main/extensions_table.h | 1 + >> src/mesa/main/mtypes.h | 1 + >> 5 files changed, 15 insertions(+) >> >> diff --git a/src/compiler/glsl/ast_to_hir.cpp >> b/src/compiler/glsl/ast_to_hir.cpp >> index dd60a2a87f..09ce5a44e6 100644 >> --- a/src/compiler/glsl/ast_to_hir.cpp >> +++ b/src/compiler/glsl/ast_to_hir.cpp >> @@ -3461,6 +3461,11 @@ apply_image_qualifier_to_variable(const struct >> ast_type_qualifier *qual, >> } >> >> var->data.image_format = qual->image_format; >> + } else if (state->has_image_load_formatted()) { >> + if (var->data.mode == ir_var_uniform && >> + state->EXT_shader_image_load_formatted_warn) { >> + _mesa_glsl_warning(loc, state, "GL_EXT_image_load_formatted used"); > > I'm confused by this. IIRC the warn stuff is so that you get a warning > when you try to enable an ext that's not available (the options are > "enable", "warn", and "require" -- the latter fails the compile while > the first two allow you to handle it with #ifdef GL_EXT_foo).
As was pointed out to me, warn is precisely what Rhys had originally - a warning when you use some extension feature. We utterly fail at this in mesa though. So this can stay then... _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
