On 2018-03-27 16:29:34, Ian Romanick wrote: > Do *all* drivers set binary formats count >= 1? Like... i915?
I don't see the extension as implying that a driver supports >= 1 binary formats. Rather, the extension just defines what enum Mesa can use with the *_get_program_binary extensions. I really hope no one ever looks for this extension and alters their usage of get_program_binary based on this extension. The application can get all the information they need for get_program_binary without knowing anything about this extension. Maybe this is a reason to not advertise the extension? -Jordan > On 03/27/2018 03:22 PM, Jordan Justen wrote: > > This extension defines an enum that can be used with > > GL_ARB_get_program_binary and GL_OES_get_program_binary. > > > > There is no reason for an application to check for this extension, > > since the *_get_program_binary extensions will return whatever enum > > value is appropriate for that implementation. Nevertheless, it is > > trivial to advertise the extension. > > > > Fixes: b4c37ce2140 "i965: Add ARB_get_program_binary support using > > nir_serialization" > > Suggested-by: Dongwon Kim <[email protected]> > > Signed-off-by: Jordan Justen <[email protected]> > > --- > > src/mesa/main/extensions_table.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/mesa/main/extensions_table.h > > b/src/mesa/main/extensions_table.h > > index 492f7c3d20a..ed7d40ab78a 100644 > > --- a/src/mesa/main/extensions_table.h > > +++ b/src/mesa/main/extensions_table.h > > @@ -322,6 +322,7 @@ EXT(KHR_texture_compression_astc_ldr , > > KHR_texture_compression_astc_ldr > > EXT(KHR_texture_compression_astc_sliced_3d , > > KHR_texture_compression_astc_sliced_3d , GLL, GLC, x , ES2, 2015) > > > > EXT(MESA_pack_invert , MESA_pack_invert > > , GLL, GLC, x , x , 2002) > > +EXT(MESA_program_binary_formats , dummy_true > > , GLL, GLC, x , ES2, 2017) > > EXT(MESA_shader_integer_functions , > > MESA_shader_integer_functions , GLL, GLC, x , 30, 2016) > > EXT(MESA_texture_signed_rgba , EXT_texture_snorm > > , GLL, GLC, x , x , 2009) > > EXT(MESA_tile_raster_order , MESA_tile_raster_order > > , GLL, GLC, x , ES2, 2017) > > > _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
