From: Emil Velikov <[email protected]> During development the version was bumped, yet the comment did not get an update.
Cc: Daniel Stone <[email protected]> Fixes: c80c08e2260 ("vulkan/wsi/x11: Add support for DRI3 v1.2") Signed-off-by: Emil Velikov <[email protected]> --- Mildly related: the DRI3 (and DRI2) version query implementation is broken. In a sense that the server can return version greater than the client one. I can set a fix for that, although it might regress some broken (yet barely working) programs. From the DRI3 proto, with some emphasis from your truly: The client sends the highest supported version to the server and the server sends the highest version it supports, but _no_ _higher_ than the _requested version_. --- src/vulkan/wsi/wsi_common_x11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c index e7a7da19285..0667aa1dbc9 100644 --- a/src/vulkan/wsi/wsi_common_x11.c +++ b/src/vulkan/wsi/wsi_common_x11.c @@ -1047,7 +1047,7 @@ x11_image_init(VkDevice device_h, struct x11_swapchain *chain, image->pixmap = xcb_generate_id(chain->conn); if (image->base.drm_modifier != DRM_FORMAT_MOD_INVALID) { - /* If the image has a modifier, we must have DRI3 v1.1. */ + /* If the image has a modifier, we must have DRI3 v1.2. */ assert(chain->has_dri3_modifiers); cookie = -- 2.16.0 _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
