I've now read through the whole thing and sprinkled some comments. Over-all, I think it's looking pretty good.
There are a couple of bits of follow-on work that could be done: 1) Now that we have indirect clear colors, we can allow non-default clear values for texturing and transfer ops in ANV. This is mostly a matter of making anv_blorp hand off the clear address in more cases and then enabling it in anv_layout_to_fast_clear_type 2) Add a new I915_FORMAT_MOD_Y_TILED_CCS_CLEAR modifier and wire it up in Vulkan and GL. This will require adding a third fake plane for the CLEAR_COLOR state. Neither of those need to be done as a prerequisite to landing this and you don't have to be the one to do them. However, I thought I should write it down somewhere. On Wed, Feb 21, 2018 at 1:45 PM, Rafael Antognolli < [email protected]> wrote: > Rebase of this series after lots of aux surface changes on anv. > > Cc: Jason Ekstrand <[email protected]> > Cc: Jordan Justen <[email protected]> > Cc: Topi Pohjolainen <[email protected]> > > Rafael Antognolli (13): > anv/image: Do not override lower bits of dword. > genxml: Preserve fields that share dword space with addresses. > intel/genxml: Use a single field for clear color address on gen10. > intel/isl: Update size of clear color value. > intel/genxml: Add Clear Color struct. > intel/isl: Add support to emit clear value address. > intel/blorp: Add suport for fast clear address. > i965/miptree: Add space to store the clear value in the aux surface. > i965/blorp: Update the fast clear color entry buffer. > i965/surface_state: Emit the clear color address instead of value. > i965/surface_state: Silence warning. > anv: Emit the fast clear color address, instead of value. > anv: Use clear address for HiZ fast clears too. > > src/intel/blorp/blorp_genX_exec.h | 12 ++++-- > src/intel/genxml/gen10.xml | 15 +++++-- > src/intel/genxml/gen11.xml | 7 ++-- > src/intel/genxml/gen_pack_header.py | 9 +++- > src/intel/isl/isl.c | 29 +++++++++---- > src/intel/isl/isl.h | 14 +++++++ > src/intel/isl/isl_surface_state.c | 18 ++++++-- > src/intel/vulkan/anv_device.c | 19 +++++++++ > src/intel/vulkan/anv_image.c | 53 > ++++++++++++++++++------ > src/intel/vulkan/anv_private.h | 8 +++- > src/intel/vulkan/genX_cmd_buffer.c | 52 > +++++++++++++++++++++-- > src/mesa/drivers/dri/i965/brw_blorp.c | 26 ++++++++++++ > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 18 +++++++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 10 +++++ > 14 files changed, 245 insertions(+), 45 deletions(-) > > -- > 2.14.3 > >
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
