On 31 January 2018 at 07:17, Tapani Pälli <[email protected]> wrote:
> Patch moves functions higher so that we can utilize them from
> test_disk_cache_create which is modified by next patch.
>
> Signed-off-by: Tapani Pälli <[email protected]>
> ---
I realise you're just moving stuff, so feel free to ignore the nits.
> src/compiler/glsl/tests/cache_test.c | 70
> ++++++++++++++++++------------------
> 1 file changed, 35 insertions(+), 35 deletions(-)
>
> diff --git a/src/compiler/glsl/tests/cache_test.c
> b/src/compiler/glsl/tests/cache_test.c
> index 75319f1160..dd11fd5944 100644
> --- a/src/compiler/glsl/tests/cache_test.c
> +++ b/src/compiler/glsl/tests/cache_test.c
> @@ -147,6 +147,41 @@ check_directories_created(const char *cache_dir)
> expect_true(sub_dirs_created, "create sub dirs");
> }
>
> +static bool
> +does_cache_contain(struct disk_cache *cache, const cache_key key)
> +{
> + void *result;
> +
> + result = disk_cache_get(cache, key, NULL);
> +
> + if (result) {
> + free(result);
> + return true;
> + }
> +
> + return false;
> +}
Nit:
void *result = disk_cache_get(cache, key, NULL);
if (!result)
return false;
free(result);
-Emil
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
