Quoting Emil Velikov (2018-01-19 10:28:18) > On 17 January 2018 at 21:34, Dylan Baker <[email protected]> wrote: > > Currently there is not a separate option for setting the search path of > > DRI drivers in meson, like there is in scons and autotools. This is an > > oversight and needs to be fixed. This adds an extra option > > `dri-search-path`, which will default to the value of > > `dri-drivers-path`, like autotools does. > > > > v2: - Split input list before joining. > > > I was wondering for a while, if we really need both options in autotools. > > Esp. since to use a custom loader one needs to > LD_PRELOAD/LD_LIBRARY_PATH it already. > Thus adding the LIBGL_DRIVERS_PATH is trivial, either way. > > The following approach is a bit shorter and easier to read. > > dri_search_path = get_option('dri-search-path') > iif dri_search_path == '' > dri_search_path = dri_drivers_path > endif > > -Emil
That won't actually do what we want, because the argument is comma delimited, but the pound define needs to be semi-colon delimited. I picked this approach because when we move to a newer meson version we can take advantage of meson's native array type argument, which use commas. I'd be happy to drop this option if you want to drop it from autotools as well. Dylan
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
