On 22 January 2018 at 15:12, Chuck Atkins <[email protected]> wrote: > Signed-off-by: Chuck Atkins <[email protected]> Please include your follow-up reply/context as commit message.
> // arch-specific dll entry point > PUBLIC struct pipe_screen *swr_create_screen_internal(struct sw_winsys > *winsys); > > +// cleanup for failed screen creation > +PUBLIC void swr_destroy_screen_internal(struct swr_screen **screen); > + I'm fairly sure you don't need to make this function public. It's used within the same binary - libmesaswr.la. Regardless if built-in or separate DSO's are used. With the above two suggestions: Cc: [email protected] Reviewed-by: Emil Velikov <[email protected]> -Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
