On 12 November 2017 at 13:55, Gert Wollny <[email protected]> wrote: > Hello all, > > this might be a bit over-zealos, but I usually prefer to compile with > -Wall -Wextra, and with mesa this gives many warnings. This series > silences most of the warnings that are issued when compiling the > C files in gallium/aux/util. > I wish more projects were using Wall and Wextra :-)
A couple of fly-by suggestions: - you are adding the notation at the end - the more common format used in Mesa is UNUSED [static] [const] $type $variable - I'm a little confused on the distinction between UNUSED and MAYBE_UNUSED Looking at some patches - you're using both in seemingly the same scenario. Might be worth using the same one or mentioning why. - some patches have funny looking double-space before UNUSED HTH Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
