This is a really rubbish solution. Yes, it fixes a crash in MPV but unless we disable all blorp on gen4-5 (which I don't think is possible anymore), we haven't actually fixed it for real.
On Thu, Nov 9, 2017 at 7:21 AM, Emil Velikov <[email protected]> wrote: > From: Emil Velikov <[email protected]> > > Using the codepath leads to a crashes in MPV's fullscreen mode. > Disable temporarily, until we can investigate and address properly. > > Cc: Adesh <[email protected]> > Cc: Jason Ekstrand <[email protected]> > Cc: Dylan Baker <[email protected]> > Cc: Mark Janes <[email protected]> > Fixes: 79f2a5541f9 ("i965: Use BLORP for color clears on gen4-5") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103529 > Signed-off-by: Emil Velikov <[email protected]> > --- > src/mesa/drivers/dri/i965/brw_clear.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_clear.c > b/src/mesa/drivers/dri/i965/brw_clear.c > index fe8634b3b34..6808ddfb93c 100644 > --- a/src/mesa/drivers/dri/i965/brw_clear.c > +++ b/src/mesa/drivers/dri/i965/brw_clear.c > @@ -293,7 +293,10 @@ brw_clear(struct gl_context *ctx, GLbitfield mask) > mt->stencil_mt->r8stencil_needs_update = true; > } > > - if (mask & BUFFER_BITS_COLOR) { > + /* TODO: Look into the mpv crash on g4x and enable BLORP color clears > for > + * all platforms. See: https://bugs.freedesktop.org/ > show_bug.cgi?id=103529 > + */ > + if (brw->gen >= 6 && (mask & BUFFER_BITS_COLOR)) { > brw_blorp_clear_color(brw, fb, mask, partial_clear, > ctx->Color.sRGBEnabled); > debug_mask("blorp color", mask & BUFFER_BITS_COLOR); > -- > 2.14.1 > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
