On Sun, Nov 5, 2017 at 1:09 PM, Christian Gmeiner <[email protected]> wrote: > 2017-10-30 17:16 GMT+01:00 Wladimir J. van der Laan <[email protected]>: >> Prepare for BLT-based blitting path by moving RS-based >> blitting to its own implementation file. >> >> Signed-off-by: Wladimir J. van der Laan <[email protected]> >> --- >> src/gallium/drivers/etnaviv/Makefile.sources | 1 + > > src/gallium/drivers/etnaviv/meson.build needs changed too. > >> src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 553 +------------------ >> src/gallium/drivers/etnaviv/etnaviv_clear_blit.h | 9 + >> .../drivers/etnaviv/etnaviv_clear_blit_rs.c | 595 >> +++++++++++++++++++++ > > Maybe we could move the rs specific stuff directly into > etnaviv_rs.[ch]? So we end with > etnaviv_blt.[ch] and etnaviv_rs.[ch]. (Just an idea I had during review).
I also thought about that, but kept the low/high level separation as it was already there, as I didn't want to make it inconsistent between RS and BLT. But I think it's a good idea in itself. When that's done I also think we should move the RS emit code back into etna_rs.c, that would make it self-contained. Wladimir _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
