Dylan pushed this series through our CI, and there were no regressions. Emil Velikov <emil.l.veli...@gmail.com> writes:
> [removing Neil's old email as it bounces] > > On 2 November 2017 at 19:01, Adam Jackson <a...@redhat.com> wrote: >> From: Neil Roberts <n...@linux.intel.com> >> >> It shouldn't be necessary to flush the context within the driver >> implementation because the old context is explicitly flushed in >> _mesa_make_current which is called a little further on. It is useful to >> only have a single place that flushes when switching contexts to make it >> easier to later implement the GL_KHR_context_flush_control extension. >> >> The flush in intelMakeCurrent was added in commit 5505865 to implement >> the GLX semantics that the context should be flushed when it is >> released. When the commit was made there was no flush in >> _mesa_make_current because it was only added later in 93102b4c. I think >> that later commit effectively makes the first commit redundant. >> > From EGL POV we call glFlush even before getting into the driver which > ... perhaps we should drop. > Skimming through the GLX codebase - we don't do such a thing. > > Patch seems good, but there's a tinkling gut feeling. > Can you please share a branch with Mark/Dylan for them to run through their > CI. > > Gents, if possible run the lot in an X session. As mentioned above EGL > (aka gbm as used normally) has an extra glFlush which might give [too] > optimistic results. > > -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
