On 17 October 2017 at 11:09, Eric Engestrom <[email protected]> wrote: > On Monday, 2017-10-16 16:04:06 +0000, Emil Velikov wrote: >> From: Emil Velikov <[email protected]> >> >> The function can fail. Check and teardown accordingly. >> >> Fixes: a43d286ef7f ("gbm: Add import from fd") >> Cc: Kristian Høgsberg <[email protected]> >> Signed-off-by: Emil Velikov <[email protected]> >> --- >> src/gbm/backends/dri/gbm_dri.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c >> index 4a51bd39903..9c9066e6661 100644 >> --- a/src/gbm/backends/dri/gbm_dri.c >> +++ b/src/gbm/backends/dri/gbm_dri.c >> @@ -891,6 +891,7 @@ gbm_dri_bo_import(struct gbm_device *gbm, >> __DRIimage *image; >> unsigned dri_use = 0; >> int gbm_format; >> + unsigned query; /* EGLBoolean, but we cannot include the header */ > I stand corrected - s/EGLBoolean/GLboolean/
> `bool`? <stdbool.h> is already included. > Having a skim through dri_interface.h we could drop the GL types in favour of the standard ones, all together. Any objection if I do that as a follow-up? -Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
