On 16 October 2017 at 17:33, Rowley, Timothy O <[email protected]> wrote: > Ping. This is useful for those building their own llvm. > Thanks Tim. Did not see this the first time around.
>> On Oct 3, 2017, at 3:23 PM, Rowley, Timothy O <[email protected]> >> wrote: >> >> Assert-enabled builds of llvm add _DEBUG to the LLVM_CFLAGS. >> >> This was causing a crash with swr running the ParaView >> waveletcontour.py test, due to a bug in our _DEBUG code. >> --- >> configure.ac | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/configure.ac b/configure.ac >> index 903a3979d4..b2768f46c0 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -987,6 +987,7 @@ strip_unwanted_llvm_flags() { >> echo " `$1` " | sed -E \ >> -e 's/[[[:space:]]]+-m[[^[:space:]]]*//g' \ >> -e 's/[[[:space:]]]+-DNDEBUG[[[:space:]]]/ /g' \ >> + -e 's/[[[:space:]]]+-D_DEBUG[[[:space:]]]/ /g' \ Why does SWR use _DEBUG? I can see a handful of handling (workarounds?) for DEBUG, so one could use it consistently throughout the code. Thanks Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
