On 12 October 2017 at 13:51, Eric Engestrom <[email protected]> wrote: > On Thursday, 2017-10-12 10:39:46 +0000, Emil Velikov wrote: >> From: Emil Velikov <[email protected]> >> >> The user does not need to know the specifics of the struct, as only a >> pointer to it is used. >> >> Just forward declare the struct making the header self-contained and >> effectively removing the deprecation warning coming from the Wayland >> headers. >> >> Cc: Greg V <[email protected]> >> Fixes: 5cddb1ce3c9 ("wayland: Add an extension to create wl_buffers from >> EGLImages") >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103225 >> Signed-off-by: Emil Velikov <[email protected]> > > Reviewed-by: Eric Engestrom <[email protected]> > > I think this should land regardless of whether Greg still sees a warning > on FreeBSD > Agreed and it seemingly it doesn't help in said case :-(
I've spotted a few other bits though: - wayland-cursor.h needs similar fwd declaration - patch is on the ML - wlroot glapi.h should not include eglmesaext.h One would still need to double check their includes, but it's a step in the right direction. -Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
