On Thu, 12 Jan 2012 13:44:12 +0000, Neil Roberts <n...@linux.intel.com> wrote: > Hi, > > Chad Versace <chad.vers...@linux.intel.com> wrote: > > > [chad]: Make comments more concise. Change the if-condition to be > > compatible with a core context, which may not advertise old extensions.
I think when we do core contexts, we'll want to keep flagging
EXT_whatever in the Mesa structures so we don't have to go rewrite all
those checks, anyway.
> The change to the if-condition breaks the patch. The problem is this bit
> of code in fbobject.c:
>
> static struct gl_framebuffer *
> get_framebuffer_target(struct gl_context *ctx, GLenum target)
> {
> switch (target) {
> case GL_DRAW_FRAMEBUFFER:
> return ctx->Extensions.EXT_framebuffer_blit && ctx->API == API_OPENGL
> ? ctx->DrawBuffer : NULL;
> ...
> }
> }
>
> That limits using GL_DRAW_FRAMEBUFFER to OpenGL even if the
> GL_EXT_framebuffer_blit extension is supported by the context. As I
> mentioned in the bug report, maybe it would be better to just remove
> that check? Then the patch wouldn't be needed anyway.
That would start allowing API that's not supposed to exist in GLES to
work, right?
pgpdxKtVU2KQQ.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
